https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #69 from Andrew Isherwood <andrew.isherw...@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #64) > 1) QA script: Fixed > 2) I am wondering a bit about the date operations in the Logger module, > get_epoch especially. What's concerning you about this? All it does is get the epoch value for dates returned so we can sort them for display. It doesn't modify them in any way > 3) This doesn't need to be part of the installer outside the sysprefs.sql > file. > Files ill_logging_pref.txt and ill_logging_pref.sql can be removed. Done > 4) I wonder if we should set the logger to off by default for updated > installations and allow people to turn it on themselves. I don't know really. I guess we need to be consistent with what other logging modules do. Do they default to off or on? > 5) For translations it's always nice to be specific. Done > 6) In the log viewer, could we make the visibility of the ILL parts depend on > the system preference? I agree. This is a great idea. However, looking at the log viewer code and template, there's currently no way of setting the visibility of a logging module based on a syspref. Presumably, the need has never arisen before. I'm not sure this bug is the place to add that, since it's a more generic mechanism in the log viewer, rather than just special casing ILL. As I say, it's a great idea, I'm just not sure it should be done here. Happy to do it if you disagree however. > 7) Just using this for a teaching moment Mmmm, good point. That will have been a typo, the space should never have been inside the <b> tag. Fixed > 8) Tests are failing for me: Fixed Thanks very much for the feedback, much appreciated! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/