http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |[email protected] --- Comment #6 from Paul Poulain <[email protected]> --- QA comment: * discussing of this feature with Marcel=if you select "private" list, the other 3 flags are irrelevant. In the future, users will be able to share private lists with who they want. * perlcritic in C4/VirtualShelves.pm was complaining before the patch and after the patch, so I won't reject it, but it would be nice to fix it in a later patch: C4/VirtualShelves.pm: Subroutine prototypes used at line 224, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: Subroutine prototypes used at line 255, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: "return" statement with explicit "undef" at line 354, column 22. See page 199 of PBP. (Severity: 5) C4/VirtualShelves.pm: Subroutine prototypes used at line 661, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: Don't modify $_ in list functions at line 664, column 5. See page 114 of PBP. (Severity: 5) No other comment, passed QA -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
