http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #25 from Paul Poulain <[email protected]> --- QA comments: * perlcritic problem: C4/HoldsQueue.pm: Don't modify $_ in list functions at line 571, column 27. See page 114 of PBP. (Severity: 5) * why is this code in this patch? +sub _flush_preferences { + %sysprefs = (); +} * we're supposed not to add anything to C4::, but use Koha:: instead. You're creating HoldsQueue.pm. As we haven't defined a clear organization for Koha::, I can't say where this code should be, it's probably fair to have it in C4. Plus I don't want Koha:: be filled with C4:: like scripts, so won't reject the patch for this reason The line: # XXX GetHoldsQueueItems() does not support $itemtypeslimit! should be # FIXME GetHoldsQueueItems() does not support $itemtypeslimit! Just a question, not related to QA: if the syspref is OFF, how are things sorted ? as before ? (if yes, good point you've set the value to 0 by default, it means there won't be any change for users) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
