http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #16 from Paul Poulain <[email protected]> --- (In reply to comment #15) > Changing status back to "signed off" because the first patch needs QA from > someone other than Ian, please. Melia, when you say "1st patch", are you talking of 3.6.x or http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9487 (Talking Tech Support - Phase I) ? QA comments (considering the 3.6.x patch is irrelevant) 1- the 3 patches (excludint 3.6.x one) apply smoothly on master 2- I tested with the syspref OFF (default), no noticeable change, as expected 3- the 2 new scripts does not pass perlcritic: misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl: Two-argument "open" used at line 63, column 4. See page 207 of PBP. (Severity: 5) misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Bareword file handle opened at line 87, column 4. See pages 202,204 of PBP. (Severity: 5) misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Two-argument "open" used at line 87, column 4. See page 207 of PBP. (Severity: 5) misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Bareword file handle opened at line 90, column 4. See pages 202,204 of PBP. (Severity: 5) 4- You changed the signature of the Enqueueletter sub: - return $result; + return $dbh->last_insert_id(undef,undef,'message_queue', undef); However, others use of this sub weren't managing any returned value, so that's not a problem. Please fix 3 and explain what should be done with the 3.6.x patch (obsoleted ?) to earn passed QA status -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
