https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774
Josef Moravec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] Status|Signed Off |Failed QA --- Comment #132 from Josef Moravec <[email protected]> --- Sorry, but QA tools are not happy: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/additional-fields.tt FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 180) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt FAIL forbidden patterns forbidden pattern: merge marker (=======) (line 212) forbidden pattern: merge marker (>>>>>>>) (line 214) forbidden pattern: merge marker (<<<<<<<) (line 206) FAIL valid_template parse error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt line 225: unexpected end of input FAIL serials/serials-search.pl FAIL valid serials/serials-search.pl had compilation errors. Global symbol "$additional_fields" requires explicit package name (did you forget to declare "my $additional_fields"?) Global symbol "$additional_field_filters" requires explicit package name (did you forget to declare "my $additional_field_filters"?) Also, I have one concern: this patchset does much more than this report describes. I would like to see, at least the refactoring part of this code (change to Koha::Object and adapt current codebase on it) as own report. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
