https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420
--- Comment #4 from Tomás Cohen Arazi <[email protected]> --- Created attachment 85755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85755&action=edit [ALTERNATIVE] Bug 22420: Remove wrong calaculation on approved tags Before the patch from bug 14385, the passed structure (that is returned by get_approval_rows() looks like: \ [ [0] { approved 1, approved_by 51, approved_by_name undef, date_approved "2019-02-26 15:36:42", term "another", weight_total 3 }, [1] { ... After the introduced 'filtering', we loose the information about the term weight!: \ [ [0] { approved 1, author "Heylin, Clinton.", biblionumber 1, borrowernumber 51, date_created "2019-02-26 15:36:37", language undef, subtitle [], tag_id 1, term "word", time_created_display "15:36:37", title "E Street shuffle :", visible 1, XSLTBloc " <<<BUNCH OF GENERATED HTML HERE>>> ... The code even calls GetMarcBiblio. This needs to be reverted as it is plain wrong. If it was worth removing *some* biblios from the weight_total value, then this calculation should be done somewhere else, without fetching the MARC data again. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
