https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750
--- Comment #102 from Andrew Isherwood <andrew.isherw...@ptfs-europe.com> ---
(In reply to Josef Moravec from comment #99)
> Comment on attachment 85697 [details] [review]
> Bug 20750: Allow logging of arbitrary actions
>
> ::: Koha/Illrequest/Logger.pm
> @@ +110,5 @@
> > +
> > +sub log_status_change {
> > + my ( $self, $req, $new_status ) = @_;
> > +
> > + $self->set_data({
>
> I do not like to use 'data' variable to send data to logger. What happens
> when log_something is called accidentaly?
Interesting. This does seem overly convoluted, I'm sure there must have been a
reason why I implemented it this way, rather than just send the data to be
logged to log_something. I'll do some digging and see if I can remember. If I
can't find any good reason, I'll just pass the data to log_something, rather
than set it as an instance variable. Thanks! :)
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
