https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #64 from Jonathan Druart <[email protected]> --- I am not convinced by the changes made to GetMarcFromKohaField. I would not cache anything here as GetMarcSubfieldStructure already cached it. In my test it does not bring any performances boost. I know we need improvement boost, but if it goes against consistency and code readability/maintainability I think we are not going to the right direction: => Use of raw SQL statements => Duplication of code (when we are trying to centralize it) - item type calculation Also it seems that tests are missing (`git grep UseHidingRulesWithBorrowerCategory t` does not return anything). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
