http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621
Paul Poulain <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #16 from Paul Poulain <[email protected]> --- QA comment: Fails QA for 2 reason, plus one request * Your patch introduce a perlcritic error: C4/Circulation.pm: Integer with leading zeros: "02" at line 976, column 41. See page 58 of PBP. (Severity: 5) * The description of the syspref look a little bit too complex to me: "Do not prevent patrons from checking out an item whose age restriction would apply". Saying "No" means "do not not prevent from ..." That's a typical "no-no" thing. It's much readable to have a yes-yes: "Prevent patrons from checking out..." "Yes/No". * for existing setups, it will be necessary to do some manual operations: - Add the Age Restriction marker and link it to biblioitems.agerestriction - if the Age Rescrition marker is already here, an UPDATE will be needed (something like "UPDATE biblioitems SET agerestriction=ExtractValue('@521$a',marcxml)") to fill the new biblioitems field That's worth adding a wiki page describing that and pointing to it during updatedatabase (I'll take care of this in the Release Notes as well) Note that this script is MARCflavour agnostic, so it should work in UNIMARC as well, (probably with field 333) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
