https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86379|0 |1 is obsolete| | Attachment #86380|0 |1 is obsolete| | Attachment #86385|0 |1 is obsolete| | Attachment #86386|0 |1 is obsolete| | Attachment #86388|0 |1 is obsolete| | Attachment #86389|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <[email protected]> --- Created attachment 86390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86390&action=edit Bug 22483: Explicitly ban 'undef' as a valid $flagsrequired Before bug 22031 the haspermission subroutine signature allowed for passing 'undef' to mean 'any permission' in $flagsrequired. This feels like a mistake and was only in practical use in two places in the codebase. This patch explicitly forbids this practice (`*` may be used to the same result and is more explicit in it's nature) and replaces the two instances of it's use. Test Plan 1. Before this patch, the API tests are all failing with authentication errors 2. After this patch the API tests should now all pass. 3. t/db_dependent/Auth/haspermission.t should continue to pass (with one addition subtest added herin) 3. /svc/members/search is not unit tested. Please check that patron searching still yields results in the UI after this patch. Signed-off-by: Martin Renvoize <[email protected]> Signed-off-by: Kyle M Hall <[email protected]> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
