https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450
Hayley Mapley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72835|0 |1 is obsolete| | Attachment #72836|0 |1 is obsolete| | --- Comment #27 from Hayley Mapley <[email protected]> --- Created attachment 86588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86588&action=edit Bug 18450: (Follow up) Only show Override button for renewals according to relevant sysprefs This patch is a follow up which corrects the conditional that uses the system preferences AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverridecontrols to control the display of the 'Override and renew' button, in addition to the 'Continue without renewing' button, when renewing an item that has been placed on hold. This patch also adjusts the expected results for each step in the test plan outlined in the previous patches to align better with the system preferences. Test plan: --NOTE-- The following renewals must be completed in Circulation->Renew 1) Apply the patch, and ensure the following steps work as described 2) In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Don't allow' 3) Item Level/Only one available item: Try to renew an item (with item level hold on it) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 4) Record Level/Only one available item: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 5) Item Level/Multiple available items: Try to renew an item (with item level hold on it) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 6) Record Level/Multiple available items: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 7) Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable system preferences to 'Allow' 8) Repeat step 3, and note only the 'Continue without renewing' button is displayed in the yellow message box 9) Repeat step 4, and note the only button in the yellow message box displayed is 'Continue without renewing' 10) Repeat step 5, note only the 'Continue without renewing' button is displayed (because the hold is for that specific item) 11) Repeat step 6, note the item is immediately renewed and the yellow message box is not displayed 12) Set the AllowRenewalIfOtheritemsAvailable to 'Don't Allow' and repeat steps 3-6, and note that only the 'Continue without renewing' button is displayed 13) Set the AllowRenewalIfOtherItemsAvailable system preference back to 'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and repeat steps 3-5 and note only the 'Continue without renewal' button is displayed. 14) Repeat step 6 and note that the item is immediately renewed with no yellow warning box. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
