https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645
--- Comment #20 from Jonathan Druart <[email protected]> --- I had a very quick look at the patch and eyeballed: 1. Do not include css/staff-global.css but css/src/staff-global.scss instead 2. +# warn user if they are using mysql/admin login => This is no longer possible 3. Koha::Patron should not contain raw SQL queries. sub check_if_patrons_have_flags should be replaced with "filter_by_with_flags" (or filter_by_something) and looks like: my $patron_without_flags = $self->search({ flags => undef })->count; I let you do the logic for the return value ;) 4. in admin/preferences.pl you are replacing 4 spaces indent with 3 spaces. It's against the coding guidelines and will add merge conflicts. Not a good idea :) There is also debug statements (warn) and empty spaces changes. 5. Is team.inc a copy of about.tt? Also not a good idea, we should have this list only once (we already have it twice actually docs/history.txt and about.tt) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
