https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551
Bug ID: 22551
Summary: Stray "//" appears at bottom of opac-detail.tt
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
Target Milestone: ---
Created attachment 86822
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86822&action=edit
screenshot of stray characters
In the "SocialNetworks" JavaScript area of the OPAC display, there's this code
(currently lines 1390-1393 of opac-detail.tt):
//<![CDATA[
{lang: '[% lang | html %]'}
//]]>
</script>
It seems like an opening <script> tag is missing (the closing one is orphaned)
which results in the "//" characters displaying on the page towards the very
bottom (see screenshot). It's not 100% clear to me what this code was intended
to do but I think it was meant to be part of the old Google+ (removed from Koha
earlier this year) script tag like this:
<script src="https://apis.google.com/js/plusone.js"; type="text/javascript">
//<![CDATA[
{"lang":"en-US"}
//]]>
</script>
However, right now it's only effect is the stray "//"—the JS code is commented
out and even if it wasn't I don't think declaring {"lang": "en-US"} as an
object literal unassigned to any variable has any effect.
I can make a patch for this shortly.
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
