https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159
--- Comment #41 from Marcel de Rooy <[email protected]> --- QA Comment: Saw this warning once: Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc line 84. False warning from qa tools: Koha/Patron/Attribute.pm critic/forbidden patterns: forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) A dumb question: + return Koha::Patron::Attributes->search({ + borrowernumber => $self->borrowernumber, + branchcode => $self->branchcode, + }); => Is the branchcode needed? Koha/Patron/Attribute.pm L114 return $av->next->lib if $av->count Amended: adding a semicolon for future ease. Koha/Schema/Result/BorrowerAttribute.pm => Please do not add DBIx schema files in a regular patch. I removed it now. Btw it seems no longer necessary if we rename the relation in the Koha object. See follow-up. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
