https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22644 Status|In Discussion |Signed Off --- Comment #14 from Jonathan Druart <[email protected]> --- Second pass and I think it's ready to get a first QA feedback. Regarding my previous commit message: (In reply to Jonathan Druart from comment #3) > Note: This patch is not ready for inclusion yet and is published to get > feedback. There are several things that will block its inclusion: > * TODO: "Delete" button must delete the file Done in a new patch "Delete the public file on deleting the upload" > * See TODO and FIXME in the patch One FIXME is new and could be fixed later, unless someone has a good idea about how to fix it, the second one is not related to these patches. The TODO (in direct_url) can be considered as an enhancement. > * Tests and POD for new methods are missing I had trouble providing tests (they do not pass currently), see bug 22644. POD has been added by a new patch "Add POD" > * Variable naming is not perfect Not blocker (?) > * In discussion - what about the upload of files from outside of the > cataloguing plugin? Could be done later, if it is needed. > * TODO: add check to the about page (?) Done in a new patch "Add warnings to about page" > * FIXME: in upload_public_path the files are not suffixed by the > filename as it is for upload_path. We certainly want to be consistent > here. The original request I got was to have a "clean" URL (read: without spaces, "weird" characters, UTF-8, etc.). The easiest was to only use the hash, I am not sure how we would answer this need matching the current behavior. As Hugo signed those patches off, I am switching the status accordingly. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
