https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #146 from Katrin Fischer <[email protected]> ---
Comment on attachment 87711
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87711
Bug 14957: Merge rules system for merging of MARC records

Review of attachment 87711:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14957&attachment=87711)
-----------------------------------------------------------------

::: C4/Biblio.pm
@@ +262,3 @@
>  =cut
>  
>  sub ModBiblio {

4) Changes to ModBiblio should be covered by unit tests.

@@ +3615,4 @@
>      return $record;
>  }
>  
> +=head2 ApplyMarcMergeRules

5) New method needs to be covered by unit tests.

::: admin/marc-merge-rules.pl
@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see <http://www.gnu.org/licenses>.
> +
> +use strict;
> +use warnings;

6) Should be: Modern::Perl

7) Changes to kohastructure.sql are missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to