https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22688
Bug ID: 22688
Summary: TT plugin for piickup locations code wrong
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Hold requests
Assignee: [email protected]
Reporter: [email protected]
QA Contact: [email protected]
CC: [email protected]
Target Milestone: ---
I haven't spent the time to determine the consequences, but bug 7614 got wrong
at some point on rebasing and this code looks plain wrong, looking at the
patches history in bugzilla it seems that the lines prefixed with minus sign
need to be removed:
sub pickup_locations {
my ( $self, $params ) = @_;
- $params->{search_params} ||= {};
- $params->{search_params}->{pickup_location} = 1;
- return $self->all($params);
my $selected = $params->{selected};
my $libraries = Koha::Libraries->pickup_locations($params);
for my $l (@$libraries) {
if ( defined $selected and $l->{branchcode} eq $selected
or not defined $selected
and C4::Context->userenv
and $l->{branchcode} eq C4::Context->userenv->{branch} )
{
$l->{selected} = 1;
}
}
return $libraries;
}
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
