https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed --- Comment #82 from Katrin Fischer <[email protected]> --- Leaving some first notes here. Ere, can you please have a look? Nothing that keeps me from testing more for now, but it will help to have follow-ups and answers :) I Code review Good: - QA test tools pass - Clean database update - New tests pass Bad (blocker): - git grep bibliosubtitle.subtitle still shows several occurrences to be fixed - Can you explain the use of $raw on the subtitle in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tt and koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelf.tt Non-blocker notes: - Need to leave a note on Taiga/bug here that the Koha-to-keyword content needs to be removed from the manual - Will need extensive release notes notes. Pre-existing: - GetHoldsQueueItems: biblioitems.publicationsyear is listed twice in the SQL query - Why so many occurrences of [% subtitl %]? - The ',' between subtitles will in opac-results.pl, opac-showreviews-rss.tt will look not work for MARC21 libraries using proper ISBD punctuation in their records. II Questions: - In the database update we don't check if libraries had already mapped the fields to other database columns. The remapping might leave data and reports orphaned. Should we check for this and at least print a warning? - What is our recommendation on how to populate the new db fields? Can we imagine something that works faster than touch_all_biblios.pl? SQL updates? What's the difference between touch_all_biblios.pl and batchRebuildBiblioTables.pl? - Why was the -t test option removed from batchRebuildBiblioTables.pl? - AFAIK UNIMARC doesn't have ISBD punctuation in the records. Do we need to introduce a separator for UNIMARC between title and subtitle? There is one place where we already seem to deal with this in opac-detail.pl: <title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle | html %][% ELSE %]Koha online[% END %] catalog › Details for: [% title | html %][% FOREACH subtitl IN subtitle %][% IF Koha.Preference('marcflavour')=='UNIMARC' %],[% END %] [% subtitl | html %][% END %]</title> -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
