https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Josef Moravec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #127 from Josef Moravec <[email protected]> --- Started QA, found some first issues: When editing holding marc record, i am able to change framework to default and acquisition, is it intended? The holdings marc editor need to be upgraded to new style introduce by bug 22045. Could be done in own bug report or on bug 21280 I think. QA test tools report: FAIL C4/Biblio.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/ImportBatch.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/Items.pm FAIL valid "my" variable $item masks earlier declaration in same statement "my" variable $item masks earlier declaration in same statement FAIL C4/Search.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL C4/XSLT.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Exporter/Record.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Holdings.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/OAI/Server/ListBase.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/OAI/Server/Repository.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL Koha/Template/Plugin/Holdings.pm FAIL valid "my" variable $item masks earlier declaration in same statement FAIL admin/marc_subfields_structure.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL catalogue/detail.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL catalogue/showmarc.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/addholding.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/additem.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/value_builder/marc21_field_008_holdings.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL cataloguing/value_builder/marc21_leader_holdings.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cat-toolbar.inc FAIL filters missing_filter at line 14 ( <li><a id="newholding" href="/cgi-bin/koha/cataloguing/addholding.pl?biblionumber=[% biblionumber %]#addholding">New holdings record</a></li>) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 210 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#editholding"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 210 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/addholding.pl?op=edit&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#editholding"><i class="fa fa-pencil"></i> Edit</a>) missing_filter at line 211 ( <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/cataloguing/addholding.pl?op=delete&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]"><i class="fa fa-eraser"></i> Delete</a>) missing_filter at line 211 ( <a class="btn btn-default btn-xs delete" href="/cgi-bin/koha/cataloguing/addholding.pl?op=delete&biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]"><i class="fa fa-eraser"></i> Delete</a>) missing_filter at line 212 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#additema"><i class="fa fa-plus"></i> Add item</a>) missing_filter at line 212 ( <a class="btn btn-default btn-xs" href="/cgi-bin/koha/cataloguing/additem.pl?biblionumber=[% holding.biblionumber %]&holding_id=[% holding.holding_id %]#additema"><i class="fa fa-plus"></i> Add item</a>) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addholding.tt FAIL filters wrong_html_filter at line 358 ( › Edit <a href="/cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=[% biblionumber | html %]">[% title | html %] [% IF ( author ) %] by [% author | html %][% END %] (Record #[% biblionumber | html %])</a>) wrong_html_filter at line 359 ( › <a href="/cgi-bin/koha/cataloguing/addholding.pl?biblionumber=[% biblionumber | html %]">Holdings</a>) wrong_html_filter at line 457 ( <li><a href="#tab[% BIG_LOO.number | html %]XX">[% BIG_LOO.number | html %]</a></li>) missing_filter at line 469 ( <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag %]</a>) missing_filter at line 471 ( <span class="tagnum" title="[% innerloo.tag_lib %]">[% innerloo.tag | html %]</span>) missing_filter at line 553 ( [% subfield_loo.marc_lib %]) missing_filter at line 578 ( [% mv.javascript %]) missing_filter at line 582 ( <textarea cols="70" rows="4" id="[%- mv.id | html -%]" name="[%- mv.name | html -%]" class="input_marceditor" tabindex="1">[%- mv.value -%]</textarea>) FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 11) forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 376) FAIL js_in_body A <script> tag found inside head, must be moved to the body (see bug 17858) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_field_008_holdings.tt FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 167) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/marc21_leader_holdings.tt FAIL forbidden patterns forbidden pattern: Attribute type should not be used for script tags (bug 20053) (line 83) FAIL misc/batchRebuildHoldingsTables.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL misc/export_records.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL misc/migration_tools/bulkmarcimport.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL opac/opac-detail.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL t/db_dependent/Exporter/Record.t FAIL valid "my" variable $item masks earlier declaration in same statement FAIL t/db_dependent/Koha/Holding.t FAIL valid "my" variable $item masks earlier declaration in same statement FAIL t/db_dependent/Koha/Holdings.t FAIL valid "my" variable $item masks earlier declaration in same statement FAIL tools/export.pl FAIL valid "my" variable $item masks earlier declaration in same statement FAIL tools/stage-marc-import.pl FAIL valid "my" variable $item masks earlier declaration in same statement -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
