https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253
--- Comment #44 from Martin Renvoize <[email protected]> --- Comment on attachment 87993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87993 Bug 15253: Add Koha::Logger based logging for SIP2 Review of attachment 87993: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15253&attachment=87993) ----------------------------------------------------------------- ::: Koha/Logger.pm @@ +159,5 @@ > if ( $l =~ /(OPAC|INTRANET)\.filename\s*=\s*(.*)\s*$/i ) { > > # we only check the two default logfiles, skipping additional > ones > + if ( !-w $2 ) { > + warn "Log file $2 is not writable!"; It's this line that's fireing.. I think we must have been talking at cross purposes. Because koha-testing-docker doesn't have a writable logdir by default if you apply this patch and then run any tests that happen to use a module that uses Koha::Logger you now spam the screen with the above warning. It's just noise rather than a failure.. but it can make the test results rather cumbersome to read.. that's what I'm getting at. I think Tomas is now on the case from the koha-testing-docker side. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
