https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
Katrin Fischer <katrin.fisc...@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #187 from Katrin Fischer <katrin.fisc...@bsz-bw.de> --- 1) RELEASE NOTES - Removes the Koha to Keyword mappings - Might cause change in behaviour for people having mappign fields outside of 245bhnp or UNIMARC equivalents - Requires you to run misc/batchRebuildBiblioTables.pl to have 245bhnp displayed 2) Template Toolkit Stash I noticed some of the files use Stash. I haven't come across this so far. Can you explain? koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +[% USE Stash %] Details for <i>[% INCLUDE 'biblio-title.inc' biblio=Stash.stash() %]</i> This is a problem, because at the moment this is only used for debugging and not marked as required in the Dependencies. Adding dependency tag to the bug. 3) SplitKohaField I wonder if the use case warrants its own subroutine, it's only used in a few places and for splitting a pipe separeted string into an array: C4/Biblio.pm:sub SplitKohaField { svc/checkouts: subtitle => C4::Biblio::SplitKohaField($c->{'subtitle'}), svc/holds:use C4::Biblio qw(SplitKohaField); svc/holds: subtitle => C4::Biblio::SplitKohaField($biblio->subtitle()), 4) Template variables Right now the changes require a lot of new variables passed to the templates and some older SQL methods to be extended to SELECT additional fields. I wonder if instead of working with an INCLUDE working with a TT plugin taking the biblionumber and querying would hurt performance much. It would allow us to remove quite a bit of code I think. Also I guess in the future working with a Record object might make things easier? 5) misc/batchRebuildBiblioTables.pl I noticed that you removed the table locking. Is this safe? 6) Unrelated changes Small one: koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc And: t/db_dependent/Biblio.t - my $authorities_mod = Test::MockModule->new( 'C4::AuthoritiesMarc' ); + my $authorities_mod = Test::MockModule->new( 'C4::Heading' ); 7) Repeatable subfields np Testing with: 245abhnpnp Multiple np show as: The C programming language / Zusatz Number | Number2 Part | Part2 Actually this is a deeper rabbit hole... as we don't keep the sequence we might lose meaning here, but that would not have worked before. Maybe this would make things a little easier? http://template-toolkit.org/docs/manual/VMethods.html#method_split 8) Good news - Removal of permission complete - Removal of Koha to keywords feature complete - Removal of GetRecordValue and Biblio:subtitles complete -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/