https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928
--- Comment #43 from AgustÃn Moyano <[email protected]> --- Created attachment 89338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89338&action=edit Bug 18928: Add Branches.HasCirculationRules and set branchcode in CirculationRules.Search This patch tackles two issues: 1) Defaults row always says (not set) because "default_rules" param was deleted from smart-rules.pl. 2) When setting standard hold rules for all libraries, hold policy, pickup and return always says 'Not Set' even if you defined values. This is because "current_branch" variable was used in CirculationRules.Search, and current_branch value for default is "*". Solutions: 1) Add Koha::Template::Plugin::Branches->HasCirculationRules method that returns 1 if defined branch has circulation rules. 2) Switch "current_branch" for "branchcode" whose value is undef for default rules. To test: 1) Apply previous patches 2) set default values for all libraries CHECK => hold policy, pickup and return remains in 'Not set' 3) select a library 4) set values for that library CHECK => first column always says "Defaults (not set)" 5) Apply this patch SUCCESS => Hold, pickup and return default values for all libraries are now shown => First column of default rules, and of the library selected in step 3 only says "Defaults" 6) Sign off -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
