https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <[email protected]> --- Sorry, but there are some issues: 1) The new preference needs to be added to sysprefs.sql 2) The QA script fails (easy fix): FAIL t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t OK critic FAIL forbidden patterns forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 75) forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 79) forbidden pattern: tab char (line 81) forbidden pattern: tab char (line 82) 3) The tests fail: # Subtest: Templates applied using simple and advanced MARC Editor 1..13 ok 1 - MARC modification template successfully created ok 2 - MARC modification template action successfully created # Looks like you planned 13 tests but ran 2. not ok 1 - Templates applied using simple and advanced MARC Editor # Failed test 'Templates applied using simple and advanced MARC Editor' # at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 154. Can't use string ("444") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Biblio.pm line 1162. # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests 4) I think maybe we should remove "Edit" from the preference name if it also applies on saving. Maybe: UseMarcModificationTemplate or DefaultMarcModificationTemplate? Native speakers might have other ideas. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
