https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407
--- Comment #77 from David Cook <[email protected]> --- (In reply to Martin Renvoize from comment #76) > We've not released yet.. perhaps we could change it to in_iprange quickly > before it's set in stone forever more. > > What do you think David, does that sound more appropriate? If folk are willing, I'd say yes to changing it. How about "in_ip_ranges"? If we look at the current "sub in_ipset", we see the following line: my @allowedipranges = split(' ', $ipset); Probably makes sense to use "ranges" or "range_list" since that's the terminology used by Net::CIDR as well: https://metacpan.org/pod/Net::CIDR#@cidr_list=Net::CIDR::range2cidr(@range_list); (Actually, if I really wanted to split hairs, I'd say "@allowedipranges" should probably be changed to "@ip_ranges", as theoretically this function could also be used to interrogate a list of IP ranges to block. Yay code re-use!) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
