http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233
Ian Walls <koha.sek...@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sek...@gmail.com --- Comment #10 from Ian Walls <koha.sek...@gmail.com> --- Display of Solr configuration page in Admin is unconditional; will show if Zebra is the search engine... not sure if that's a bad thing or not. opac/opac-search.pl makes use of "highly experimental" Perl syntax: given and when. http://perldoc.perl.org/perlsyn.html#Switch-Statements. While this should be compatible with Koha's minimum Perl version (5.10), it's still listed as experimental in 5.16, which makes me nervous. I'm all for switch statements, but they're not as fundamental in Perl as they are in other languages, and for an either/or situation like this, doing it another way would be safer. Reintroduces Test::MockModule Given the above, I'm not ready to pass this through QA, but I'm not entirely convinced it should fail, either. Replacing "given" with "for", and adding a 'default' case should clear up the issue. Otherwise, all the code is new and in it's own area, making it delightfully low-impact on folks who aren't ready to experiment with Solr support. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/