http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

Robin Sheat <ro...@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #9 from Robin Sheat <ro...@catalyst.net.nz> ---
Things noted:

10-1. If you forgot to run the backup command, then there is nothing to choose
from but the download button is still there. Not a big issue, just slightly
cosmetic. Also, the "no downloads exist" message is missing, I think due to
different semantics between T::T and perl about whether an empty array is
considered "true."

10-2. This doesn't work with the packages, as it's testing -o (do I own this
file) not -r (can I read this file.) Dumps provided by the packages are owned
by root, but readable by the webserver due to group permissions. This needs to
be fixed in getbackupfilelist and download_backup.

My signed off patch fixes these.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to