https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057
Kyle M Hall <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91326|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <[email protected]> --- Comment on attachment 91326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91326 Bug 23057: (QA follow-up) Stay closer to old code I agree with Liz of course ;) The old code is messy and confusing. I put a lot of thought into the changes I made to make the code clean, terse and understandable. I don't think we should put back bad code just for the sake of leaving it unchanged in this case. There is very real benefit to the new code consolidating logic for the benefit of future developers who have to deal with this code. (In reply to Marcel de Rooy from comment #24) > Kyle, > Please have a look at the last follow-up. And let me know if you are > comfortable with it. I am at least, since we stay closer to the old code > while resolving the bug. If you are too, I will pass QA. > > Marcel -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
