https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] --- Comment #3 from Katrin Fischer <[email protected]> --- Hi Julian, nice patch! 1) Some complaints form the QA script: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters wrong_html_filter at line 173 ( <li><a href="#[% tab.id %]">[% tab.title %]</a></li>) missing_filter at line 173 ( <li><a href="#[% tab.id %]">[% tab.title %]</a></li>) missing_filter at line 173 ( <li><a href="#[% tab.id %]">[% tab.title %]</a></li>) 2) Wondering: What happens if the tab name consists non-latin characters, diacritics etc. Will this still work ok as id? + $tab->{id} = $tab->{title}; + $tab->{id} =~ s/[^\w]+/-/g; I've found this looking for valid characters in ids: he value must not contain any space characters. HTML 4: ID and NAME tokens must begin with a letter ([A-Za-z]) and may be followed by any number of letters, digits ([0-9]), hyphens ("-"), underscores ("_"), colons (":"), and periods ("."). 3) Can you please document the new hooks on the wiki (once we have this in PQA)? https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
