https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23111

Hayley Mapley <hayleymap...@catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #12 from Hayley Mapley <hayleymap...@catalyst.net.nz> ---
(In reply to Tomás Cohen Arazi from comment #10)
> I'm sorry but this seems to me like a over-complicated approach: why don't
> we add a 'default' column with a boolean value to the biblio_framework table?
> Paired with a Koha::BiblioFramework->set_default method that unsets the
> previous default when called. And that's it? You will need
> Koha::BiblioFrameworks::get_default as well if you want to avoid crafting
> the query.
> 
> in addbiblio.pl you use Koha::BiblioFramework (singular class) and you
> shouldn't. WE only include the plurals, which in turn include the singular.

Hi Tomás,

Have included a follow-up patch to change the use statements to plural classes.

We're looking into your suggestions now.

How do you see the interface for this implemented? 
i.e. How should the librarians in your opinion set a framework to be the
default?

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to