https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669
--- Comment #9 from Katrin Fischer <[email protected]> --- (In reply to Liz Rea from comment #8) > Hi Katrin, > > This works but it has a QA tool failure that I don't understand because it > seems to be set up correctly: > > FAIL koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc > FAIL valid_template > options_for_libraries: not found > > IT may be a false positive, if it is just let me know and I'll sign it off. > > Cheers, > Liz After some checking I believe it's a false positive: The BLOCK options for libraries is defined in html_helpers.inc koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers.inc:[% BLOCK options_for_libraries %] doc-head-close.inc includes html_helpers.inc: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:[% PROCESS 'html_helpers.inc' %] And koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt includes doc_head-close.inc. ... and the file koha-tmpl/intranet-tmpl/prog/en/includes/filter-orders.inc is included in histsearch.tt I think the test might not cope well with all this. I am still amending the patch to make a slight change: In the first version the filter preselected on the user's current branch which will limit search results and change behaviour. I have now changed it to select 'All libraries' by default. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
