https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354
--- Comment #30 from Tomás Cohen Arazi <[email protected]> --- (In reply to Martin Renvoize from comment #29) > (In reply to Tomás Cohen Arazi from comment #28) > > The feature works, and the code is pretty clean. I have a few remarks to be > > considered: > > > > - We should really have a separate table and stop using MANUAL_INV. It feels > > really dirty to have a note field contain a decimal value to be used as a > > number. To start with. I think we agree on this, and there's even work from > > Josef that would do it. > > Totally agree here.. I was taking the pragmatic approach of not letting that > work hold this up as we already have the MANUAL_INV code in place.. I intend > to switch to our own table as a further bug down the line as we have more > sponsorship in the pipeline for adding features which would require that > distinction. Ok. > > - Things look misaligned to me (hidpi laptop). > > Did you run the yarn build? I've tried to fix alignment once already, but > perhaps there are some bits still needing a little work. That must be it. Re-testing today. > > - 'Collected from patron' should reuse some patron searching things already > > exist in the codebase. Thinking of the dialog to pick a guarantor. > > Not sure what you mean here? The 'Collected from patron' input is meant to > be a monetary value. (Though I do also like the idea of enhancing the screen > to allow a patron to be optionally linked to the transaction) I got it wrong! Ok! > > - Currency symbol is the pound one, no matter what the system is configured > > to use. > > Oops.. I'll post a followup for that now. > > > - 'Click on the item cost' maybe instead of 'Click on the item'. > > Good catch. > > > - Are you planning on having an inventory of things to sell? I think the use > > of authorised values is very limited, besides my criticism. I expect > > librarians wanting to just scan the barcode and get the price on the screen. > > I very much do want to add such functionality, including things like > barcodes, tax rates etc.. but I see that as part of a bigger piece to > migrate MANUAL_INC outside of authorized values. I mentioned it only just in case we could spot something on the code preventing such enhancement being a smooth addition. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
