https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23586
--- Comment #9 from Katrin Fischer <[email protected]> --- (In reply to Andreas Jonsson from comment #7) > Since the problem is likely caused by the confusion caused by the fact that > the variable name $branch is sometimes used for branchnumbers and sometimes > for library objects I think that it is a good idea to change the variable > names. > > Also, I think it would be a good idea to add to the coding standards how to > name variables containing objects and object identities. > > These types of errors should really be caught by a type system at compile > time. But in the absense of a type system, we can at least improve the > situation by having a consistent variable naming scheme. > > The QA-team could also consider performing tests with the mysql query log > enabled and querying for patterns like '=HASH(' which could catch some > problems. The issue is not the idea, but that this patch is marked for 19.05 - so the variable renaming would never make it into master. If we want to do that, we need to make sure there is a patch for master and a backport - it should probably be done on a separate bug report (but leaving to RM ;) ) -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
