https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445
--- Comment #73 from Jonathan Druart <[email protected]> --- (In reply to Martin Renvoize from comment #72) > With the plethora of schemes out there I must admit I'm not entirely > comfortable with the choice of `%` character being used: > > > Of the ASCII character set, the characters : / ? # [ ] @ are reserved for > > use as delimiters of the generic URI components and must be percent-encoded > > – for example, %3F for a question mark.[15] The characters ! $ & ' ( ) * + > > , ; = are permitted by generic URI syntax to be used unencoded in the user > > information, host, and path as delimiters.[10][16] Additionally, : and @ > > may appear unencoded within the path, query, and fragment; and ? and / may > > appear unencoded as data within the query or fragment. > > So, given the above quote, one could find that we are misinterpreting % in > our regex when it's being used as an escape character. > > I'm not too worried about whether we mimic TT syntax here or not so long as > what we do offer is well documented alongside the preference itself. Which character would you suggest then? :) The substitutions are like: $url =~ s|%normalized_isbn%|$normalized_isbn|g So whichever we pick should be safe. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
