https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |ommunity.org --- Comment #37 from Jonathan Druart <[email protected]> --- (In reply to Martin Renvoize from comment #31) > Created attachment 94284 [details] [review] > Bug 23382: Fix logic in C4::Circulation::CanBookBeIssued > > It looks like over progressive rebases of bug 20912 a clause was lost > within CanBookBeIssued such that a fatal error may be triggered if an > item with no corresponding itemtype was passed into the routine. Did not we agree we should not test the assumption? We now have a script to catch such inconsistencies, moreover we are suppose to add a FK to unsure it will never happen again. (In reply to Martin Renvoize from comment #35) > Created attachment 94288 [details] [review] > Bug 23382: Truncate dates to minutes for comparison. > > It's somewhat of a mess in C4::Circulation as to when dates are > truncated and when they are not and as such Koha::Charges::Fees could > not reliably assume that the dates passed in were consistent with each > other. As such, we take the approach of always truncating to the > greatest minute smaller than the passed in dates so we are comparing > like for like. How can we test that patch? Do we have test to cover it? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
