https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049
--- Comment #208 from Martin Renvoize <martin.renvo...@ptfs-europe.com> ---
(In reply to Marcel de Rooy from comment #207)
> (Minor) If you archive a debit type, you should probably be no longer
> allowed to create a manual invoice with that type.
Corrected on the branch now.
> (Minor) UPDATE accountlines SET accounttype = ? WHERE accounttype = ?
> => Hope you dont have too many clashes on the prefix here ;) The algorithm
> now just assumes that it should be the first one found. But hard to solve..
Agreed, I did think about this but when I looked at out customer base I
couldn't find any cases in real life so i decided this was better than leaving
the mess.
> (Minor) UPDATE accountlines SET accounttype = 'MANUAL' WHERE accounttype =
> 'M'
> => How do you know that you are not moving sundry to manual fee here? Or is
> that okay (did we manage to get rid of it completely) ?
I believe this is resolved in previous bugs already. the two accounttypes were
merged.
> (Major) t/db_dependent/api/v1/patrons_accounts.t
> not ok 5 - 200 OK
> # Failed test '200 OK'
> # at t/db_dependent/api/v1/patrons_accounts.t line 95.
> # got: '500'
> # expected: '200'
> not ok 6 - exact match for JSON Pointer ""
> # Failed test 'exact match for JSON Pointer ""'
> # at t/db_dependent/api/v1/patrons_accounts.t line 95.
> # Structures begin differing at:
> # $got->{balance} = Does not exist
> # $expected->{balance} = '100.01'
> not ok 11 - 200 OK
> # Failed test '200 OK'
> # at t/db_dependent/api/v1/patrons_accounts.t line 139.
> # got: '500'
> # expected: '200'
> not ok 12 - exact match for JSON Pointer ""
> # Failed test 'exact match for JSON Pointer ""'
> # at t/db_dependent/api/v1/patrons_accounts.t line 139.
> # Structures begin differing at:
> # $got->{outstanding_debits} = Does not exist
> # $expected->{outstanding_debits} = HASH(0x55d12cacfd80)
> => Some other tests with API calls do pass.
Looking into this one at the moment.
> (Major) Three other tests still fail. Related to new constraint on type
> check.
I can't replicate these failures still :(
--
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
