https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #36 from Marcel de Rooy <[email protected]> --- (In reply to Marcel de Rooy from comment #15) > Failing QA because this patch has side-effects when you cancel a hold from > the confirm hold popup. Before we called GetOtherReserves and now we dont. Still looking at my older comment, and having the feeling that it was kind of ignored. Let me rephrase it by showing this diff part: } else { my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ? $diffBranchReturned : undef; + # diffBranchSend tells ModReserveAffect whether document is expected in this library or not, # i.e., whether to apply waiting status ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend, $reserve_id ); - } -# check if we have other reserves for this document, if we have a return send the message of transfer - my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber); As you can see here, the GetOtherReserves call and code around it was placed AFTER the else, but we remove the closing accolade and put the new code INTO the else branch. So what happens: if you come from the if branch (you canceled a hold), you wont jump into the GetOtherReserves stuff anymore. Still does not look good to me. Please convince me with some good arguments! -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
