https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809

--- Comment #19 from Marcel de Rooy <[email protected]> ---
(In reply to Julian Maurice from comment #17)
> It would be great to have Jonathan's opinion as he wrote the patch for bug
> 18539

Looking back, I think that the biggest problem was using ->find in parameter 
hashes like { var1 => KO->find, var2 => etc }. Here we have list context and if
there was no result, we were returning an empty list causing a parameter/value
shift.
This comes from:
    return unless $result;

Since your patch does not return empty list, we would not suffer from that.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to