https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831

Ere Maijala <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #11 from Ere Maijala <[email protected]> ---
The url is a nice touch! A few issues remain, though: 

1.) I'd still fetch the base urls outside the loop. Would improve readability
and avoid repeated pref calls.

2.) For authorities, the OPAC URLs are now invalid. They should be something
like [...]/cgi-bin/koha/opac-authoritiesdetail.pl?authid=123.

3.) The patch for PerlDependencies.pl is borked.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to