https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075
--- Comment #7 from Kyle M Hall <[email protected]> --- I like it! Updated patch incoming! (In reply to Martin Renvoize from comment #6) > Comment on attachment 95654 [details] [review] > Bug 24075: Backdating a return to the exact due date and time results in the > fine not being refunded > > Review of attachment 95654 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +1966,4 @@ > > MarkIssueReturned( $borrowernumber, $item->itemnumber, > > $return_date, $patron->privacy ); > > }; > > unless ( $@ ) { > > + if ( $return_date_is_forced || ( > > C4::Context->preference('CalculateFinesOnReturn') && $is_overdue && > > !$item->itemlost ) ) { > > This feels somewhat wrong.. I'm sure Katrin would say "But we don't ever > want to recalculate fines if we have 'CalculateFinesOnReturn' turned off" > > So.. could this perhaps be: > > `if ( C4::Context->preference('CalculateFinesOnReturn') && > ($return_date_is_forced || $is_overdue) && !$item->itemlost ) {` > > Instead? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
