http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |[email protected] | |m Assignee|[email protected] |[email protected] |m | --- Comment #5 from Jonathan Druart <[email protected]> --- QA Comments: 1/ Please use use strict; use warnings; OR use Modern::Perl; 2/ Perltidied for misc/maintenance/batchSanitizeEntity.pl 3/ Bad encoding (N°) Technically: 4/ $count += 1; => $count++; 5/ +# We remove spaces +my @biblio; +foreach my $bib(@biblios) { + $bib =~ s/(^\s*|\s*$)//g; + next if $bib eq ""; + push @biblio, $bib; +} +@biblios = @biblio; The second tmp array is useless: # We remove spaces s/(^\s*|\s*$)//g for @biblios; # Remove empty lines @biblios = grep {!/^$/} @biblios; 6/ if ($biblios =~ /\//) is more readable as: if ( $biblio =~ m|/| ) for example 7/ + while (my $bib = $sth-> fetchrow_array()){ There is a useless space ;-) Marking as Failed QA for 1 and 2 -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
