https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
--- Comment #52 from Martin Renvoize <[email protected]> --- OK, the patch doesn't apply currently, SHA1 errors. However, I think I agree with Jonathan here, I'm not sure there's a requirement at all for introducing a Koha::Item::LastPatron object.. we have a nice method in Koha::Item for returning a Koha::Patron object for the last_borrower. I think we can simply inline the search and removal here rather than adding a new class. Finally.. as for the 'update' debate.. personally I think we should ban update calls as a direct passthrough in Koha::Objects but allow the manual "I know what I'm doing" reach inside _resultset version. So, I would encourage _resultset->update() as the format for that particular case. -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
