http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813
Jonathan Druart <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #3 from Jonathan Druart <[email protected]> --- (early) QA Comments : 1/ The commit message notices "PATCH 3/3". Where are the 2 first commits ? I think this one is the unique one :) 2/ The indentation is 4 spaces to separate blocks. It is not the case in this patch (8 or 0 in several cases, the average is good but it is not what is expected :-) ). 3/ if ( cond ) {} else { //some instructions } should be replaced with unless ( cond ) { //some instructions } -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
