https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Katrin Fischer <[email protected]> --- Hi Nick, I thouhgt it would be very nice to revive this bug and looked at your WIP patch. I think you were on the right track there, but I'd like to suggest some changes to the regex. You got: $data =~ s/[.\-,]$//; I've tested with authors and made some changes on my data: Without patch: Aristophanes, Aristophanes. Beckett, Samuel, Celan, Paul. Date, C. J. With patch: Aristophanes. Beckett Samuel, Celan Paul. Date C. J. 1) Your regex always removes the first occurence, but we need the last. 2) . is not removed as it's not escaped in the regex (I think). 2) In case of "Date, C. J." we don't want the last, when it's preceded by a capital letter (very likely to be an initial). -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
