https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793

--- Comment #16 from David Roberts <[email protected]> ---
Thanks Katrin, I didn't know that. I'll try to do that in future! Thanks for
QA'ing the patch and for your changes.

David (apparently AKA Patrick! :-D )


(In reply to Katrin Fischer from comment #13)
> Hi Patrick, there are some small things that I've fixed in the patch for you:
> 
> 1) Please make sure your editor uses 4 spaces instead of tabs, tabs are
> forbidden :)
> 
>  FAIL tools/modborrowers.pl
>    OK   critic
>    FAIL         forbidden patterns
>               forbidden pattern: tab char (line 267)
>               forbidden pattern: tab char (line 268)
>               forbidden pattern: tab char (line 269)
>               forbidden pattern: tab char (line 270)
>               forbidden pattern: tab char (line 271)
>               forbidden pattern: tab char (line 272)
> 
> 2) Make sure you include the test plan in your commit message.
> 
> 3) Make sure you start the first line of your commit message with Bug XXXX:
> (not - as in bugzilla).
> 
> I'll continue testing and upload the patch later.

-- 
You are receiving this mail because:
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

Reply via email to