https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064
Hayley Mapley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95611|0 |1 is obsolete| | --- Comment #10 from Hayley Mapley <[email protected]> --- Created attachment 97753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97753&action=edit Bug 23064: Use Koha::Subscription in ModSubscription We must use Koha::Subscription instead of raw SQL. It will fix issue with default and integer values. Test plan: Edit a subscription and set number of issues = "f" Save => Without this patch there is a SQL error in the log: Incorrect integer value: 'f' for column 'numberlength' => With this patch the other changes are effective. Note: We also could change the type attribute of the input to "number", to have a client-side check Also, the return value of ModSuggestion is never used, so we are safe with that. Signed-off-by: Hayley Mapley <[email protected]> The <strict_sql_modes> flag must be present and set to 1 in the <config> section of koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
