https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24269
--- Comment #7 from Nick Clemens <[email protected]> --- (In reply to Martin Renvoize from comment #4) > Comment on attachment 97982 [details] [review] > Bug 24269: Adjust C4::Heading to generate headings from auth tags > > Review of attachment 97982 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Heading.pm > @@ +52,5 @@ > > > > Given a C<MARC::Field> object containing a heading from a > > bib record, create a C<C4::Heading> object. > > > > +The optional third parameter is 'auth' - it is handled as boolean. If > > supplied we treat the field as an auth record field. Otherwise if it is a > > bib field. The fields checked are the same in a UNIMARC system and this > > parameter is ignored > > I'm not sure I understand this rewording.. you've removed the > '$marc_flavour' param right, and instead, always use the application > context? I think this could be more clearly worded. I did, I didn't mention it in the POD, meant to mention in the commit message - we had that option, but it was never used and I didn't see a reason to preserve it -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
