https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22690
--- Comment #21 from Martin Renvoize <[email protected]> --- Comment on attachment 98143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98143 Bug 22690: Refactor merging of records to improve performance (Elasticsearch) Review of attachment 98143: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22690&attachment=98143) ----------------------------------------------------------------- This looks like a reasonable approach to me and seems to work well.. a relatively minor point regarding the introduce Koha/Biblio method. ::: Koha/Biblio.pm @@ +854,5 @@ > +Move items from the given biblio > + > +=cut > + > +sub move_items_from_biblio { I feel like 'move_items_from_biblio' isn't immediately obvious as a function name.. are we moving from 'this' biblio or to it.. perhaps 'adopt_items_from_biblio' is a bit clearer? -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
