http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8531
Priority: P5 - low
Change sponsored?: ---
Bug ID: 8531
CC: [email protected]
Assignee: [email protected]
Summary: Staff hold requests generate silent errors
Severity: normal
Classification: Unclassified
OS: All
Reporter: [email protected]
Hardware: All
Status: NEW
Version: rel_3_6
Component: Hold requests
Product: Koha
Created attachment 11215
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11215&action=edit
Proposed patch to placerequest.pl
This bug extends the bug #8474
Silent errors occur when a librarian makes holds using staff interface.
The reason is uninitialized or wrong value and generally logical mistakes in
line block: 115 - 123 in module placerequest.pl
In line 115: if ($input->param('request') eq 'any'){
parameter is compared to string 'any' whereas should be 'Any'. The other wrong
thing is lack of value when the parameter hasn't value 'Any'.
Due to this reasons always is realized only one line of code updating the
reservation table (what is right):
AddReserve($branch,$borrower->{'borrowernumber'},$biblionumber,'a',\@realbi,$rank[0],$startdate,$expirationdate,$notes,$title,$checkitem,
$found);
regardles the reservation is done on a first available or a given item.
My proposition is to modify and simplify this block of lines like that (see
also attached differential listing):
if ($multi_hold) {
my $bibinfo = $bibinfos{$biblionumber};
AddReserve($branch,$borrower->{'borrowernumber'},$biblionumber,'a',[$biblionumber],
$bibinfo->{rank},$startdate,$expirationdate,$notes,$bibinfo->{title},$checkitem,$found);
} else {
AddReserve($branch,$borrower->{'borrowernumber'},$biblionumber,'a',\@realbi,$rank[0],$startdate,$expirationdate,$notes,$title,$checkitem,
$found);
}
}
Proposed patch refers to Koha 3.6.4 version as well as 3.6.6 and 3.8
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Koha-bugs mailing list
[email protected]
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
