https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299
--- Comment #115 from Nick Clemens <[email protected]> --- Overall this works and I agree, it is a much desired functionality. Test plan missing step: Must enable BiblioAddsAuthorities Blockers: When creating a new record the popup does not close / links not added automatically The record is saved an picked up if I relink sub AddAuthorityFromHeading - can this just be an option for AddAuthority? I don't understand why it is in C4/Biblio.pm - it checks the heading for things like 'series_added_entry' - i cannot identify where in the code these are being set sub GetRecordValue - added but not used? Change to POD in Linker.pm doesn't seem to have corresponding code change? Why a change to default linker behavior? -if ( $behavior eq 'default' && $#{$authorities} == 0 ) { +if ( $behavior eq 'default' && $#{$authorities} >= 0 ) { automatic_linker.pl - duplicates a lot of code from C4/Biblio->BiblioAutoLink - we should rather pass verbose option through that sub - should this be in svc? I am a bit confused about new param biblioindex vs index, we only ever seem to pass index, unless I missed something here Without edit authorities permission I get a warning that I cannot use the 'Link authorities automatically' button - I shouldn't see it if I can't use it As has been noted, test coverage is needed for changes to modules Other improvement, could be on new bug: 1 - This doesn't work with the advanced cataloging editor - code should be made flexible enough that can be done 2 - If links are changed they become green - if button clicked again they are not green - may not be obvious that I still need to save changes - i think a second run should preserve what was changed since the record was opened/created. 3 - The notice about links should show the headings that were linked/not-linked otherwise it can be confusing which individual 650 had an issue - colors are nice but we should no rely only on colors for accessibility 4 - The js uses hardcoded styles for colors - can this be made css so the js just adds a class, would allow easier override by users -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
