https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881
Katrin Fischer <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Katrin Fischer <[email protected]> --- Hi Nicolas, starting with QA review here: 1) QA test tools Possibly a false positive: FAIL Koha/Desk.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL Koha/Desks.pm FAIL pod coverage POD is missing for 'object_class' Possibly a false positive: FAIL Koha/Schema/Result/Desk.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 FAIL koha-tmpl/intranet-tmpl/prog/en/includes/desks-admin-search.inc FAIL filters missing_filter at line 3 (<h1 id="logo"><a href="/cgi-bin/koha/mainpage.pl">[% LibraryName %]</a></h1><!-- Begin Desks Resident Search Box -->) missing_filter at line 7 ( <form action="[% script_name %]" method="post">) missing_filter at line 8 ( <input class="head-searchbox" type="text" name="desk_name" value="[% searchfield %]" size="40" />) FAIL forbidden patterns forbidden pattern: tab char (line 5) forbidden pattern: tab char (line 7) forbidden pattern: tab char (line 9) forbidden pattern: tab char (line 10) forbidden pattern: tab char (line 11) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 24) forbidden pattern: tab char (line 28) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/desks.tt FAIL filters missing_filter at line 79 ( <option value="[% branch.branchcode %]" selected="selected">[% branch.branchname %]</option>) missing_filter at line 79 ( <option value="[% branch.branchcode %]" selected="selected">[% branch.branchname %]</option>) missing_filter at line 81 ( <option value="[% branch.branchcode %]">[% branch.branchname %]</option>) missing_filter at line 81 ( <option value="[% branch.branchcode %]">[% branch.branchname %]</option>) 2) Quick code review admin/desks.pl Are the copyright statements correct? +# Copyright 2006 SAN OUEST-PROVENCE et Paul POULAIN +# Copyright 2015 Koha Development Team Leftover debugging code: +use Data::Dumper; The new page requires a new permission: manage_desks + flagsrequired => { parameters => 'manage_desks' }, But the new permission is not properly added. It looks like maybe you were planning to use manage_libraries here instead? Check: koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc -- You are receiving this mail because: You are watching all bug changes. _______________________________________________ Koha-bugs mailing list [email protected] https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
